Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove load_as_component and update doc #684

Merged
merged 6 commits into from
Oct 20, 2023
Merged

refactor: remove load_as_component and update doc #684

merged 6 commits into from
Oct 20, 2023

Conversation

elliotzh
Copy link
Contributor

@elliotzh elliotzh commented Oct 8, 2023 •
edited
Loading

Description

Remove previous interface load_as_component and update corresponding tests and documents.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh temporarily deployed to internal October 8, 2023 03:36 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 03:36 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 03:36 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 03:36 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 03:36 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

SDK CLI Global Config Test Result zhangxingzhi/flow-in-pipeline-new-experience

2 tests   2 ✔️  38s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 78ee54a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

SDK PFS E2E Test Result zhangxingzhi/flow-in-pipeline-new-experience

8 tests   8 ✔️  27s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 78ee54a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

Executor Unit Test Result zhangxingzhi/flow-in-pipeline-new-experience

    2 files      2 suites   2m 16s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit 78ee54a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

Executor E2E Test Result zhangxingzhi/flow-in-pipeline-new-experience

    2 files      2 suites   7m 24s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit 61a85e3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

SDK CLI Test Result zhangxingzhi/flow-in-pipeline-new-experience

    2 files      2 suites   25m 22s ⏱️
303 tests 290 ✔️ 13 💤 0 ❌
606 runs  580 ✔️ 26 💤 0 ❌

Results for commit 61a85e3.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh force-pushed the zhangxingzhi/flow-in-pipeline-new-experience branch from c60dea8 to f741481 Compare October 8, 2023 04:06
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:06 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:06 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:06 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:06 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:06 — with GitHub Actions Inactive
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-in-pipeline-new-experience branch from f741481 to 1dae18b Compare October 8, 2023 04:53
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:53 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:53 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:53 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:53 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 04:53 — with GitHub Actions Inactive
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-in-pipeline-new-experience branch from 1dae18b to 5a86ad1 Compare October 8, 2023 05:38
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 05:38 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 05:38 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 05:38 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 05:38 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 8, 2023 05:38 — with GitHub Actions Inactive
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-in-pipeline-new-experience branch from f06c8fd to a38a92b Compare October 20, 2023 07:10
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:11 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:11 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:11 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:11 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:11 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:52 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:52 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:52 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:52 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 07:52 — with GitHub Actions Inactive
@elliotzh elliotzh marked this pull request as ready for review October 20, 2023 07:52
@elliotzh elliotzh requested a review from a team as a code owner October 20, 2023 07:52
zhengfeiwang
zhengfeiwang previously approved these changes Oct 20, 2023
View reviewed changes
@elliotzh elliotzh changed the title feat: remove load_as_component and update doc refactor: remove load_as_component and update doc Oct 20, 2023
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-in-pipeline-new-experience branch from 61a85e3 to 78ee54a Compare October 20, 2023 09:34
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 09:34 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 09:34 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 09:34 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 09:34 — with GitHub Actions Inactive
@elliotzh elliotzh temporarily deployed to internal October 20, 2023 09:34 — with GitHub Actions Inactive
@elliotzh elliotzh merged commit 089f18d into main Oct 20, 2023
35 of 37 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/flow-in-pipeline-new-experience branch October 20, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 left review comments

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@0mza987 0mza987 0mza987 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Improvements on examples fundamental promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elliotzh @0mza987 @zhengfeiwang @wangchao1230